On 2024.01.10 06:51, Linus Arver via GitGitGadget wrote: > This patch series is the first 10 patches of a much larger series I've been > working. The main goal of this series is to enrich the API in trailer.h. The > larger series brings a number of additional code simplifications and > cleanups (exposing and fixing some bugs along the way), and builds on top of > this series. The goal of the larger series is to make the trailer interface > ready for unit testing. By "trailer API" I mean those functions exposed in > trailer.h. I agree with Junio's points, and I added a small nitpick about patch 8's commit message. But apart from that, this all looks good to me and I'm interested in seeing the followup series as well. Thanks! Reviewed-by: Josh Steadmon <steadmon@xxxxxxxxxx>