On 2024.01.10 06:51, Linus Arver via GitGitGadget wrote:
> From: Linus Arver <linusa@xxxxxxxxxx>
>
> Expose more functions in the trailer.h API, in preparation for moving
> out
>
> parse_trailers_from_command_line_args()
>
> to interpret-trailer.c, because the trailer API should not be concerned
> with command line arguments (as it has nothing to do with trailers
> themselves). The interpret-trailers builtin is the only user of the
> above function.
>
> Signed-off-by: Linus Arver <linusa@xxxxxxxxxx>
> ---
> trailer.c | 66 +++++++++++++++++++++++++++----------------------------
> trailer.h | 10 +++++++++
> 2 files changed, 42 insertions(+), 34 deletions(-)
>
> diff --git a/trailer.c b/trailer.c
> index 360e76376b8..e2d541372a3 100644
> --- a/trailer.c
> +++ b/trailer.c
> @@ -33,7 +33,7 @@ struct trailer_block {
> size_t trailer_nr;
> };
>
> -struct conf_info {
> +struct trailer_conf {
Can you also add a note about this conf_info -> trailer_conf rename? I
agree that it's an improvement but I think it should be mentioned in the
commit message.
