On Thu, Jan 25, 2024 at 5:38 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Christian Couder <christian.couder@xxxxxxxxx> writes: > > > It seems that this topic has fallen into the cracks or something, > > while the associated pch looks good to me. > > Yeah, it wasn't clear to me that your message you are responding to > was your Reviewed-by:. If I recall my impression correctly from the > time I skimmed its proposed log message the last time, it focused on > describing a single failure case the author encountered in the real > world and said that the patch changed the behaviour to correct that > single case, and was not very clear if it was meant as a general > fix. Is the patch text, including its proposed patch description, > satisfactory to you? In other words, is the above your Reviewed-by:? Yes, it's satisfactory for me, and I am Ok to give my Reviewed-by:, thanks!
