On Sun, Jan 21, 2024 at 4:43 AM Linus Arver <linusa@xxxxxxxxxx> wrote: > > Jiang Xin <worldhello.net@xxxxxxxxx> writes: > > This v5 looks good code-wise. I've made small suggestions to make the > commit messages better, but they are just nits and you are free to > ignore them. Thanks for helping me refine commit messages. I will update them based on your suggestions in next reroll. > If you choose to reroll one more time, one additional thing you could do > is to use the word "protocol_v2" in all commit messages because that's > how that term looks like in the code (unless the "protocol-v2" string is > already the standard term used elsewhere). Will s/protocol_v2/protocol v2/