From: Jiang Xin <zhiyou.jx@xxxxxxxxxxxxxxx>
# Change since v3:
1. Update commit message of patch 2/4.
2. Add comments in t5003.
# range-diff v3...v4
1: 1818d8e30e = 1: d343585cb5 transport-helper: no connection restriction in connect_helper
2: b57524bc91 ! 2: 65fb67523c transport-helper: call do_take_over() in process_connect
@@ Commit message
where the return value from process_connect() is the return value of the
call it makes to process_connect_service().
- It is safe to make a refactor by moving the call of do_take_over()
- into the function process_connect().
+ Move the call of do_take_over() inside process_connect(), so that
+ calling the process_connect() function is more concise and will not
+ miss do_take_over().
Suggested-by: Junio C Hamano <gitster@xxxxxxxxx>
Signed-off-by: Jiang Xin <zhiyou.jx@xxxxxxxxxxxxxxx>
3: 7ce60e3b9a = 3: 109a1fffde transport-helper: call do_take_over() in connect_helper
4: 626f903508 ! 4: eb905259fe archive: support remote archive from stateless transport
@@ Commit message
Helped-by: Eric Sunshine <sunshine@xxxxxxxxxxxxxx>
Signed-off-by: Jiang Xin <zhiyou.jx@xxxxxxxxxxxxxxx>
@@ t/t5003-archive-zip.sh: check_zip with_untracked2
check_added with_untracked2 untracked one/untracked
check_added with_untracked2 untracked two/untracked
++# Test remote archive over HTTP protocol.
++#
++# Note: this should be the last part of this test suite, because
++# by including lib-httpd.sh, the test may end early if httpd tests
++# should not be run.
++#
+. "$TEST_DIRECTORY"/lib-httpd.sh
+start_httpd
+
@@ t/t5003-archive-zip.sh: check_zip with_untracked2
+setup_askpass_helper
+
+test_expect_success 'remote archive does not work with protocol v1' '
-+ test_when_finished "rm -f d5.zip" &&
+ test_must_fail git -c protocol.version=1 archive \
+ --remote="$HTTPD_URL/auth/smart/bare.git" \
-+ --output=d5.zip HEAD >actual 2>&1 &&
++ --output=remote-http.zip HEAD >actual 2>&1 &&
+ cat >expect <<-EOF &&
+ fatal: can${SQ}t connect to subservice git-upload-archive
+ EOF
@@ t/t5003-archive-zip.sh: check_zip with_untracked2
+'
+
+test_expect_success 'archive remote http repository' '
-+ test_when_finished "rm -f d5.zip" &&
+ git archive --remote="$HTTPD_URL/auth/smart/bare.git" \
-+ --output=d5.zip HEAD &&
-+ test_cmp_bin d.zip d5.zip
++ --output=remote-http.zip HEAD &&
++ test_cmp_bin d.zip remote-http.zip
+'
+
test_done
Jiang Xin (4):
transport-helper: no connection restriction in connect_helper
transport-helper: call do_take_over() in process_connect
transport-helper: call do_take_over() in connect_helper
archive: support remote archive from stateless transport
http-backend.c | 15 +++++++++++----
remote-curl.c | 14 +++++++++++---
t/t5003-archive-zip.sh | 34 ++++++++++++++++++++++++++++++++++
transport-helper.c | 29 +++++++++++++----------------
4 files changed, 69 insertions(+), 23 deletions(-)
--
2.41.0.232.g2f6f0bca4f.agit.8.0.4.dev
