"Victoria Dye via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > From: Victoria Dye <vdye@xxxxxxxxxx> > > The 'check-name' subcommand to 'test-tool submodule' is documented as being > able to take a command line argument '<name>'. However, this does not work - > and has never worked - because 'argc > 0' triggers the usage message in > 'cmd__submodule_check_name()'. To simplify the helper and avoid future > confusion around proper use of the subcommand, remove any references to > command line arguments for 'check-name' in usage strings and handling in > 'check_name()'. > > Helped-by: Jeff King <peff@xxxxxxxx> > Signed-off-by: Victoria Dye <vdye@xxxxxxxxxx> > --- > t/helper/test-submodule.c | 29 +++++++++-------------------- > 1 file changed, 9 insertions(+), 20 deletions(-) Excellent, both of you.
