Patrick Steinhardt <ps@xxxxxx> writes: > Gah, I forgot to run this with GIT_TEST_COMMIT_GRAPH=1 before sending > this patch. There are two test failures that this change introduces: > > - t6022-rev-list-missing.sh, where we test for the `--missing=` option > of git-rev-list(1). I would have expected you to enable the paranoia mode automatically when this option is in effect. > Both of these are expected failures: we knowingly corrupt the repository > and circumvent git-gc(1)/git-maintenance(1), thus no commit-graphs are > updated. If we stick with the new stance that repository corruption > should not require us to pessimize the common case,... Yeah, just like we try to be extra careful while running fsck, because "--missing" is about finding these "corrupt" cases, triggering the paranoia mode upon seeing the option would make sense, no? It would fix the failure in 6022, right? Thanks for working on this.
