On Tue, Nov 14, 2023 at 11:35:08AM +0100, Patrick Steinhardt wrote: > Gah, I forgot to run this with GIT_TEST_COMMIT_GRAPH=1 before sending > this patch. There are two test failures that this change introduces: > > - t6022-rev-list-missing.sh, where we test for the `--missing=` option > of git-rev-list(1). > > - t7700-repack.sh, where we also manually delete objects. > > Both of these are expected failures: we knowingly corrupt the repository > and circumvent git-gc(1)/git-maintenance(1), thus no commit-graphs are > updated. If we stick with the new stance that repository corruption > should not require us to pessimize the common case, then we'd have to > squash in something like the below. Good catch. Thanks for investigating and providing a thoughtful analysis of why we should turn off GIT_COMMIT_GRAPH_PARANOIA by default. I agree with your conclusion (with this follow-up patch squashed in, of course). My hunch is that it would be easier for the maintainer to have a single patch to queue instead of squashing this in themself. You may want to send a "v2" to that effect. Thanks, Taylor
