On November 4, 2023 9:49 AM, Jeff King wrote: >On Sat, Nov 04, 2023 at 02:36:48AM -0400, Eric Sunshine wrote: > >> I don't see an urgent need for it. Unlike the actual tests themselves >> run by `make test` which may catch platform-specific problems in Git >> itself, the purpose of the "linting" checks is not to catch >> platform-specific problems, but rather to help test authors by >> identifying mistakes in the tests which might make them fragile. So, >> disabling linting on a particular platform isn't going to cause `make >> test` to miss some important Git problem specific to that platform. > >Hmm. With compilation, we split the audience of "developers" vs "people who just >want to build the program", and we crank up the number and severity of warning >checks for the former. We could do the same here for tests. I.e., turn off test linting >by default and re-enable it for DEVELOPER=1. > >OTOH, this is the first time I think I've seen the linting cause a problem (whereas >unexpected compile warnings are much more likely, as we are depending on the >system compiler's behavior). > >So consider it an idle thought for discussion, and not necessarily a proposal. ;) In my case, I am building git for users of the platform (a.k.a. mostly a packager), although I'm hoping to be more involved in contributions soon. This involves build + full test under multiple situations on the NonStop platform. --Randall
