On Fri, Nov 3, 2023 at 6:04 PM <rsbecker@xxxxxxxxxxxxx> wrote: > On November 3, 2023 5:51 PM, Eric Sunshine wrote: > >On Fri, Nov 3, 2023 at 5:31 PM <rsbecker@xxxxxxxxxxxxx> wrote: > >> /usr/coreutils/bin/bash: /usr/bin/perl: Argument list too long > >> Makefile:125: recipe for target 'test-lint-shell-syntax' failed > > > >This is a separate issue from chainlint (though, it too will likely suffer the same > >problem). In this case, it's trying to run the check-non-portable-shell.pl script and > >the command-line is too long. > >Unfortunately, unlike chainlint for which there is a knob to disble it, there is no direct > >knob to disable `test-lint-shell-syntax`. You may be able to skip all the shell-script > >linting by setting TEST_LINT to an empty value. > > That worked. I wonder whether it might be useful to set up a knob for this. I don't see an urgent need for it. Unlike the actual tests themselves run by `make test` which may catch platform-specific problems in Git itself, the purpose of the "linting" checks is not to catch platform-specific problems, but rather to help test authors by identifying mistakes in the tests which might make them fragile. So, disabling linting on a particular platform isn't going to cause `make test` to miss some important Git problem specific to that platform. Also, in the longer term, as you suggested, `xargs` is likely a more fruitful solution.
