Hi Junio
On 31/10/2023 05:23, Junio C Hamano wrote:
They are equivalents and the former still exists, so as long as the
only change this commit makes are to rewrite test_i18ngrep to
test_grep, there won't be any new bug, even if there still are
callers of test_i18ngrep remaining in the tree, or when merged to
other topics that add new uses of test_i18ngrep.
This patch was produced more or less with
git grep -l -e 'test_i18ngrep ' 't/t[0-9][0-9][0-9][0-9]-*.sh' |
xargs perl -p -i -e 's/test_i18ngrep /test_grep /'
and a good way to sanity check the result yourself is to run the
above in a checkout of c4603c1c (test framework: further deprecate
test_i18ngrep, 2023-10-31) and compare the resulting working tree
contents with the result of applying this patch to the same commit.
You'll see that test_i18ngrep in a few t/lib-*.sh files corrected,
in addition to the manual reproduction.
Thanks for working on this. I have checked what you have in seen by
checking out the first parent of ce56983dd3 (Merge branch
'jc/test-i18ngrep' into seen, 2023-11-01) and then converting
"test_i18ngrep" to "test_grep" and diffing the result as you suggest
above. The diff looks good and shows that you've corrected the
additional t/lib-*.sh files. Grepping ce56983dd3 for "test_i18ngrep"
shows there is one instance of test_i18ngrep that has not been coverted
in contrib/mw-to-git/t/t9363-mw-to-git-export-import.sh.
Best Wishes
Phillip
