Junio C Hamano <gitster@xxxxxxxxx> writes: > Elijah Newren <newren@xxxxxxxxx> writes: > >> I thought the point of the comment_line_char was so that commit >> messages could have lines starting with '#'. That rationale doesn't >> apply to the TODO list generation or parsing, and I'm not sure if we >> want to add the same complexity there. Earlier I said > Thanks for a healthy dose of sanity. I noticed existing use of > comment_line_char everywhere in sequencer.c and assumed we would > want to be consistent, but you are right to point out that they are > all about the COMMIT_EDITMSG kind of thing, and not about what > appears in "sequencer/todo". but with something as simple as $ git -c core.commentchar='@' rebase -i master seen^2 I can see that the references to comment_line_char in sequencer.c are about the commented lines after the list of insn in the generated sequencer/todo file, so even though the rationale does not apply, isn't this already "broken" in the current code anyway? Thanks.