> On Oct 30, 2023, at 4:35 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Elijah Newren <newren@xxxxxxxxx> writes: > >> I thought the point of the comment_line_char was so that commit >> messages could have lines starting with '#'. That rationale doesn't >> apply to the TODO list generation or parsing, and I'm not sure if we >> want to add the same complexity there. > > Thanks for a healthy dose of sanity. I noticed existing use of > comment_line_char everywhere in sequencer.c and assumed we would > want to be consistent, but you are right to point out that they are > all about the COMMIT_EDITMSG kind of thing, and not about what > appears in "sequencer/todo”. Actually, I withdraw my previous comment. comment_line_char is all over sequencer.c, and there are tests that say, "rebase -i respects core.commentchar”, which strongly implies that the *intent* is that rebase -i respects comment_line_char. I would propose that we move forward with this, except perhaps removing more instances of comment_line_char. Thanks.
