On 27/10/2023 12:57, Patrick Steinhardt wrote:
Hum. After having a look at `ci/run-docker-build.sh` I don't feel like it's sensible to update it. It's not even used anymore by our CI but only by `ci/run-docker.sh`, which seems to be more of a developer-facing script? As you said, this smells like rotting bits that might rather be removed. But in any case, as they don't relate to our current CI infrastructure except for being in "ci/" I'll leave them be for now.
I was trying to suggest that we start using these scripts again. The fact that we run the dockerized tests as root on the other CI platforms is a regression from what we used to do. I'm not an expert but I think for the builds that use docker we're essentially using the some build environment regardless of the CI provider so it would make sense to handle them all in the same way. I think the existing script uses "su" but we could change it to use "sudo" like you're doing here.
Best Wishes Phillip
