On Sat, Oct 27, 2007 at 11:18:02PM -0700, Junio C Hamano wrote: > > We walk all the paths in $PATH collecting the names of "git-*" > > commands. To help distinguish between the main git commands > > and commands picked up elsewhere (probably extensions) we > > print them seperately. The main commands are the ones that > > are found in the first directory in $PATH that contains the > > "git" binary. > > This is not right. $(gitexecdir) in Makefile is designed to > allow distros to move git-* commands out of the primary user > $PATH directories and install only "git" wrapper in /usr/bin. > "Use the directory 'git' is in" rule breaks this. > > The "main commands" should be the first of argv_exec_path, > EXEC_PATH_ENVIRONMENT or builtin_exec_path. This is after we've already prepended the above three paths (if they're specified) to $PATH, so yes, generally they should be in one of those directories, but more generally, it will be in one of the directories in $PATH. Its not clear to me what exactly you're looking for me to change, just the wording i'm using in my comment? Or are you refering to the approach? When i email the changes, should i keep emailing the whole patch series, or just the few patches that have changed? Thanks sRp -- Scott Parish http://srparish.net/ - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
