On 10/24/23 09:00, Uwe Kleine-König wrote:
> Hello,
>
> On Fri, Oct 20, 2023 at 05:06:36PM -0400, Michael Strawbridge wrote:
>> On 10/20/23 06:04, Uwe Kleine-König wrote:
>>> hello,
>>>
>>> On Fri, Oct 13, 2023 at 04:14:37PM +0200, Uwe Kleine-König wrote:
>>>> Hello,
>>>>
>>>> $ git send-email --to 'A B <a@xxxxx>, C D <c@xxxxx>' lala.patch
>>>> Use of uninitialized value $address in sprintf at /usr/lib/git-core/git-send-email line 1172.
>>>> error: unable to extract a valid address from:
>>>>
>>>> This happens for me with git 2.42.0 and also on master (59167d7d09fd, "The seventeenth batch").
Hm. I tried reproing with master (59167d7d09fd, "The seventeenth batch") but I don't seem to see an error:
```
$ git send-email --to 'Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>' -1 --smtp-server="$(pwd)/fake.sendmail"
/tmp/FEGzLrm_4U/0001-test-test.patch
1
(mbox) Adding cc: Your Name <you@xxxxxxxxxxx> from line 'From: Your Name <you@xxxxxxxxxxx>'
(body) Adding cc: Your Name <you@xxxxxxxxxxx> from line 'Signed-off-by: Your Name <you@xxxxxxxxxxx>'
From: Your Name <you@xxxxxxxxxxx>
To: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= <u.kleine-koenig@xxxxxxxxxxxxxx>
Cc: Your Name <you@xxxxxxxxxxx>
Subject: [PATCH] test test
Date: Tue, 24 Oct 2023 18:33:51 +0000
Message-ID: <20231024183350.10-2-you@xxxxxxxxxxx>
X-Mailer: git-send-email 2.40.0.rc1.1708.gbffa95ed23.dirty
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
The Cc list above has been expanded by additional
addresses found in the patch commit message. By default
send-email prompts before sending whenever this occurs.
This behavior is controlled by the sendemail.confirm
configuration setting.
For additional information, run 'git send-email --help'.
To retain the current behavior, but squelch this message,
run 'git config --global sendemail.confirm auto'.
Send this email? ([y]es|[n]o|[e]dit|[q]uit|[a]ll): y
-i
OK. Log says:
Sendmail: /git/fake.sendmail -i u.kleine-koenig@xxxxxxxxxxxxxx you@xxxxxxxxxxx
From: Your Name <you@xxxxxxxxxxx>
To: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= <u.kleine-koenig@xxxxxxxxxxxxxx>
Cc: Your Name <you@xxxxxxxxxxx>
Subject: [PATCH] test test
Date: Tue, 24 Oct 2023 18:33:51 +0000
Message-ID: <20231024183350.10-2-you@xxxxxxxxxxx>
X-Mailer: git-send-email 2.40.0.rc1.1708.gbffa95ed23.dirty
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Result: OK
```
I think my terminal may be mangling the UTF-8 encoding but git send-email doesn't seem to complain.
Only when I go to an older git (version 2.42.0 for example) do I then get:
```
Use of uninitialized value $address in sprintf at /usr/lib/git-core/git-send-email line 1172.
error: unable to extract a valid address from:
```
This would be expected because https://public-inbox.org/git/20230918212004.GC2163162@xxxxxxxxxxxxxxxxxxxxxxx/T/#mae64003cbb72f015bf5c0c04216524fcb6bb8d09
is meant to fix it.
Just in case it was the "from" address, I tried using 'Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>'
as the from address. This still worked without issue for (59167d7d09fd, "The seventeenth batch").
>>>>
>>>> Bisection points at
>>>>
>>>> a8022c5f7b67 ("send-email: expose header information to git-send-email's sendemail-validate hook")
>>>>
>>>> I didn't try to understand that change and fix the problem.
>>>
>>> Another (similar?) problem with non-ascii-chars:
>>>
>>> $ git send-email --to 'Will Deacon <will@xxxxxxxxxx>' --to 'Krzysztof Wilczyński <kw@xxxxxxxxx>' --to 'Lorenzo Pieralisi <lpieralisi@xxxxxxxxxx>' --cc 'Rob Herring <robh@xxxxxxxxxx>' --to 'Bjorn Helgaas <bhelgaas@xxxxxxxxxx>' --cc 'linux-pci@xxxxxxxxxxxxxxx' --cc kernel@xxxxxxxxxxxxxx -1 --base=@~
>>> Use of uninitialized value $address in sprintf at /home/uwe/gsrc/git/git-send-email line 1162.
>>> error: unable to extract a valid address from:
>>>
>>> Bisection points to the same commit, when dropping ń in Krzysztof's
>>> name, it works fine.
I tried this as well with seventeen and it succeeds:
```
/tmp/GfTxbwKSx_/0001-test-test.patch
1
(mbox) Adding cc: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= <u.kleine-koenig@xxxxxxxxxxxxxx> from line 'From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= <u.kleine-koenig@xxxxxxxxxxxxxx>'
(body) Adding cc: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> from line 'Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>'
From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= <u.kleine-koenig@xxxxxxxxxxxxxx>
To: Will Deacon <will@xxxxxxxxxx>,
=?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= <kw@xxxxxxxxx>,
Lorenzo Pieralisi <lpieralisi@xxxxxxxxxx>,
Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
Cc: Rob Herring <robh@xxxxxxxxxx>,
linux-pci@xxxxxxxxxxxxxxx,
kernel@xxxxxxxxxxxxxx,
=?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= <u.kleine-koenig@xxxxxxxxxxxxxx>
Subject: [PATCH] test test
Date: Tue, 24 Oct 2023 18:57:16 +0000
Message-ID: <20231024185715.10-2-u.kleine-koenig@xxxxxxxxxxxxxx>
X-Mailer: git-send-email 2.40.0.rc1.1708.gbffa95ed23.dirty
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The Cc list above has been expanded by additional
addresses found in the patch commit message. By default
send-email prompts before sending whenever this occurs.
This behavior is controlled by the sendemail.confirm
configuration setting.
For additional information, run 'git send-email --help'.
To retain the current behavior, but squelch this message,
run 'git config --global sendemail.confirm auto'.
Send this email? ([y]es|[n]o|[e]dit|[q]uit|[a]ll): y
-i
OK. Log says:
Sendmail: /git/fake.sendmail -i will@xxxxxxxxxx kw@xxxxxxxxx lpieralisi@xxxxxxxxxx bhelgaas@xxxxxxxxxx robh@xxxxxxxxxx linux-pci@xxxxxxxxxxxxxxx kernel@xxxxxxxxxxxxxx u.kleine-koenig@xxxxxxxxxxxxxx
From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= <u.kleine-koenig@xxxxxxxxxxxxxx>
To: Will Deacon <will@xxxxxxxxxx>,
=?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= <kw@xxxxxxxxx>,
Lorenzo Pieralisi <lpieralisi@xxxxxxxxxx>,
Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
Cc: Rob Herring <robh@xxxxxxxxxx>,
linux-pci@xxxxxxxxxxxxxxx,
kernel@xxxxxxxxxxxxxx,
=?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= <u.kleine-koenig@xxxxxxxxxxxxxx>
Subject: [PATCH] test test
Date: Tue, 24 Oct 2023 18:57:16 +0000
Message-ID: <20231024185715.10-2-u.kleine-koenig@xxxxxxxxxxxxxx>
X-Mailer: git-send-email 2.40.0.rc1.1708.gbffa95ed23.dirty
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Result: OK
```
Perhaps there is another variable involved?
>>>
>> This is interesting. Thanks for reporting it. If you are able, could you please try the patches found in the below threads:
>> - https://public-inbox.org/git/20230918212004.GC2163162@xxxxxxxxxxxxxxxxxxxxxxx/T/#mae64003cbb72f015bf5c0c04216524fcb6bb8d09
>
> On main (2e8e77cbac8a) this one is already applied, with that the error
> message reduces to:
>
> $ git send-email --to 'Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>' -1
> error: unable to extract a valid address from: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
>
>> - https://public-inbox.org/git/f5c6a72b-f888-4d43-8be8-3ce2c878c669@xxxxxxxxx/T/#mca12dc95ccfd3ce2b94e7752ebaae9891201084f
>
> This one doesn't help either. With it applied on top of main I get the
> sams result as on vanilla main.
>
> Best regards
> Uwe
>
