Re: Regression: git send-email fails with "Use of uninitialized value $address" + "unable to extract a valid address"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

On Fri, Oct 20, 2023 at 05:06:36PM -0400, Michael Strawbridge wrote:
> On 10/20/23 06:04, Uwe Kleine-König wrote:
> > hello,
> > 
> > On Fri, Oct 13, 2023 at 04:14:37PM +0200, Uwe Kleine-König wrote:
> >> Hello,
> >>
> >> 	$ git send-email --to 'A B <a@xxxxx>, C D <c@xxxxx>' lala.patch
> >> 	Use of uninitialized value $address in sprintf at /usr/lib/git-core/git-send-email line 1172.
> >> 	error: unable to extract a valid address from:
> >>
> >> This happens for me with git 2.42.0 and also on master (59167d7d09fd, "The seventeenth batch").
> >>
> >> Bisection points at
> >>
> >> 	a8022c5f7b67 ("send-email: expose header information to git-send-email's sendemail-validate hook")
> >>
> >> I didn't try to understand that change and fix the problem.
> > 
> > Another (similar?) problem with non-ascii-chars:
> > 
> > 	$ git send-email --to 'Will Deacon <will@xxxxxxxxxx>' --to 'Krzysztof Wilczyński <kw@xxxxxxxxx>' --to 'Lorenzo Pieralisi <lpieralisi@xxxxxxxxxx>' --cc 'Rob Herring <robh@xxxxxxxxxx>' --to 'Bjorn Helgaas <bhelgaas@xxxxxxxxxx>' --cc 'linux-pci@xxxxxxxxxxxxxxx' --cc kernel@xxxxxxxxxxxxxx -1 --base=@~
> > 	Use of uninitialized value $address in sprintf at /home/uwe/gsrc/git/git-send-email line 1162.
> > 	error: unable to extract a valid address from:
> > 
> > Bisection points to the same commit, when dropping ń in Krzysztof's
> > name, it works fine.
> > 
> This is interesting.  Thanks for reporting it.  If you are able, could you please try the patches found in the below threads:
> - https://public-inbox.org/git/20230918212004.GC2163162@xxxxxxxxxxxxxxxxxxxxxxx/T/#mae64003cbb72f015bf5c0c04216524fcb6bb8d09

On main (2e8e77cbac8a) this one is already applied, with that the error
message reduces to:

	$ git send-email --to 'Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>' -1
	error: unable to extract a valid address from: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

> - https://public-inbox.org/git/f5c6a72b-f888-4d43-8be8-3ce2c878c669@xxxxxxxxx/T/#mca12dc95ccfd3ce2b94e7752ebaae9891201084f

This one doesn't help either. With it applied on top of main I get the
sams result as on vanilla main.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux