On 20-oct-2023 10:31:18, Junio C Hamano wrote: > Rubén Justo <rjusto@xxxxxxxxx> writes: > > > On 19-oct-2023 09:40:51, Isoken June Ibizugbe wrote: > > > >> As per the CodingGuidelines document, it is recommended that a single-line > >> message provided to error messages such as die(), error() and warning(), > > > > This is confusing; some multi-line messages are fixed in this series. What I expected to see is a re-roll with no mention about single/multi-line. > >> should start with a lowercase letter and should not end with a period. > >> Also this patch fixes the tests broken by the changes. > > "Also this patch fixes the tests broken by the changes" -> "Adjust > tests to match updated messages". That is a more palatable description of why the tests are being touched in this series. Thanks.