Re: [Outreachy][PATCH] branch.c: adjust error messages to coding guidelines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 18-oct-2023 06:12:22, Isoken June Ibizugbe wrote:

> Signed-off-by: Isoken June Ibizugbe <isokenjune@xxxxxxxxx>
> ---
>  builtin/branch.c | 66 ++++++++++++++++++++++++------------------------
>  1 file changed, 33 insertions(+), 33 deletions(-)

Only builtin/branch.c is touched.

The changes in this patch break some tests, therefore this patch must
also include the fixes for those tests.

> @@ -965,11 +965,11 @@ int cmd_branch(int argc, const char **argv, const char *prefix)
>  		const char *start_name = argc == 2 ? argv[1] : head;
>  
>  		if (filter.kind != FILTER_REFS_BRANCHES)
> -			die(_("The -a, and -r, options to 'git branch' do not take a branch name.\n"
> +			die(_("the -a, and -r, options to 'git branch' do not take a branch name\n"
>  				  "Did you mean to use: -a|-r --list <pattern>?"));

OK.  The initial 'T' is fixed, but as Junio explained [1], the full stop
must stay.


Thanks.

 [1] https://lore.kernel.org/git/xmqqttqxkmaq.fsf@gitster.g/




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux