Thank you very much for the feedback Christian, I'd definitely keep this in mind the next time I'm creating/sending a patch. You also said asides working on my commit message, the patch looks good, but as I'm applying to Outreachy, I need to send in my proof of contribution as a link of a task I worked on. Would sending a link of the mailing list , with the url of this patch I just worked on suffice?Something like this : https://public-inbox.org/git/20231009011652.1791-1-naomi.ibeh69@xxxxxxxxx/T/#u I ask because since I used patches to send to Git , I have no pull request link to submit. On Mon, Oct 9, 2023 at 8:28 AM Christian Couder <christian.couder@xxxxxxxxx> wrote: > > On Mon, Oct 9, 2023 at 3:17 AM Naomi Ibe <naomi.ibeh69@xxxxxxxxx> wrote: > > > > From: Naomi <naomi.ibeh69@xxxxxxxxx> > > First the subject should start, after "[PATCH 1/1][Outreachy]", with > the area of the code you are changing followed by ":", so here "add:" > (no need for ".c"). > > Also even if the subject gives a lot of information already, it's > better to use the body of the commit message to give a bit more > context and details. For example here either the subject or the body > of the commit message should say which specific guideline(s) the patch > is enforcing. > > > Signed-off-by: Naomi Ibe <naomi.ibeh69@xxxxxxxxx> > > --- > > builtin/add.c | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > Otherwise the patch looks good to me. > > Thanks!
