On Mon, Oct 9, 2023 at 3:17 AM Naomi Ibe <naomi.ibeh69@xxxxxxxxx> wrote: > > From: Naomi <naomi.ibeh69@xxxxxxxxx> First the subject should start, after "[PATCH 1/1][Outreachy]", with the area of the code you are changing followed by ":", so here "add:" (no need for ".c"). Also even if the subject gives a lot of information already, it's better to use the body of the commit message to give a bit more context and details. For example here either the subject or the body of the commit message should say which specific guideline(s) the patch is enforcing. > Signed-off-by: Naomi Ibe <naomi.ibeh69@xxxxxxxxx> > --- > builtin/add.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > Otherwise the patch looks good to me. Thanks!
