On Tue, Oct 3, 2023 at 4:09 PM Štěpán Němec <stepnem@xxxxxxxx> wrote: > On Tue, 3 Oct 2023 14:30:38 -0400 Eric Sunshine wrote: > > On Tue, Oct 3, 2023 at 4:28 AM Štěpán Němec <stepnem@xxxxxxxx> wrote: > >> diff --git a/contrib/README b/contrib/README > >> @@ -24,14 +24,14 @@ lesser degree various foreign SCM interfaces, so you know the > >> I expect that things that start their life in the contrib/ area > >> -to graduate out of contrib/ once they mature, either by becoming > >> +graduate out of contrib/ once they mature, either by becoming > > > > You probably want to add a comma after "area". > > That would read awkward to me. How about going the other way, > > I expect things that start their life in the contrib/ area > to graduate out of contrib/ once they mature > > instead? Sounds fine. > >> @@ -579,11 +579,10 @@ This test harness library does the following things: > >> -Here are some recommented styles when writing test case. > > > > Do you want to fix the spelling error while you're here or is that > > done in a later patch? > > > > s/recommented/recommended/ > > You really had me double-checking both the branch and the patch I sent > here. :-D Unless I'm very much missing something, that line is _removed_ > by the patch (seemed redundant given the title immediately preceding > it). Ugh, so it is. Sorry for the noise. > >> - - Keep test title the same line with test helper function itself. > >> + - Keep test titles and helper function invocations on the same line. > > > > This would be clearer if it was switched around. Either: > > > > Keep the test_expect_* function call and test title on the same line. > > > > or, more verbosely: > > > > Place the test title on the same line as the test_expect_* call > > which precedes it. > > I'll take your first suggestion. I like the first suggestion better too.
