On Tue, Sep 05, 2023 at 04:36:48PM -0400, Taylor Blau wrote: > To remove redundant packs at the end of a repacking operation, Git uses > its `remove_redundant_pack()` function in a loop over the set of > pre-existing, non-kept packs. > > In a later commit, we will split this list into two, one for > pre-existing cruft pack(s), and another for non-cruft pack(s). Prepare > for this by factoring out the routine to loop over and delete redundant > packs into its own function. > > Instead of calling `remove_redundant_pack()` directly, we now will call > `remove_redundant_existing_packs()`, which itself dispatches a call to > `remove_redundant_packs_1()`. Note that the geometric repacking code > will still call `remove_redundant_pack()` directly, but see the previous > commit for more details. > > Having `remove_redundant_packs_1()` exist as a separate function may > seem like overkill in this patch. However, a later patch will call > `remove_redundant_packs_1()` once over two separate lists, so this > refactoring sets us up for that. Heh, so this is basically the same "_1" case discussed in the earlier patch. This commit message explains the split a bit better, IMHO. :) (Not worth re-rolling; just thinking out loud). -Peff
