Re: [PATCH v4 00/15] Introduce new `git replay` command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Christian,

hope you had a restful vacation!

On Thu, 7 Sep 2023, Christian Couder wrote:

> # Changes between v3 and v4
>
> Thanks to Toon, Junio and Dscho for their suggestions on the previous
> version! The very few and minor changes compared to v3 are:
>
> * The patch series was rebased onto master at d814540bb7 (The fifth
>   batch, 2023-09-01). This is to fix a few header related conflicts as
>   can be seen in the range-diff.
>
> * In patch 10/15 (replay: make it a minimal server side command) a /*
>   Cleanup */ code comment has been removed as suggested by Toon.
>
> * In patch 11/15 (replay: use standard revision ranges) the git-replay
>   documentation related to --onto has been improved to better explain
>   which branches will be updated by the update-ref command(s) in the
>   output as suggested by Junio.
>
> * In patch 12/15 (replay: disallow revision specific options and
>   pathspecs) an error message has been improved as suggested by Junio.
>
> * In patch 13/15 (replay: add --advance or 'cherry-pick' mode) the
>   commit message and the git-replay documentation have been improved
>   to better explain that --advance only works when the revision range
>   passed has a single tip as suggested by Junio.
>
> * Also in patch 13/15 (replay: add --advance or 'cherry-pick' mode) an
>   error message has been improved, and a few tests have been added to
>   check that `git replay` fails when it's passed both --advance and
>   --onto and when it's passed none of these options, as suggested by
>   Toon.

I left a bit of feedback and think that once my concerns are addressed, a
v5 will be ready for `next`.

Ciao,
Johannes




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux