On 8/14/2023 12:02 PM, Junio C Hamano wrote: > "Derrick Stolee via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: >> +--[no-]src:: >> + Specify if the repository should be created within a `src` directory >> + within `<enlistment>`. This is the default behavior, so use >> + `--no-src` to opt-out of the creation of the `src` directory. > > While there is nothing incorrect in the above per-se, and the first > half of the description is perfectly good, but I find the latter > half places too much stress on the existence of the "src" directory. > As a mere mortal end-user, what is more important is not the > presence of an extra directory, but the fact that everything I have > is now moved one level down in the directory hierarchy to "src/" > directory. > > This is the default behavior; use `--no-src` to place the > root of the working tree of the repository directly at > `<enlistment>`. > > or something along that line would have been easier to understand > for me. It is not the creation of `src`, but that everything is > moved into it, is what some users may find unusual. Your confusion makes sense. Focusing on the location of the cloned repository is a good way to focus the option for the reader. >> +test_expect_success '`scalar clone --no-src`' ' >> + scalar clone --src "file://$(pwd)/to-clone" with-src && >> + scalar clone --no-src "file://$(pwd)/to-clone" without-src && >> + >> + test_path_is_dir with-src/src && >> + test_path_is_missing without-src/src >> +' > > And another thing that may be interesting, from the above point of > view, is to compare these two: > > (cd with-src/src && ls ?*) >with && > (cd without && ls ?*) >without && > test_cmp with without Good idea. Thanks, -Stolee
