Junio C Hamano <gitster@xxxxxxxxx> writes: >> 1. The zero value of the enum is actually GIT_DIR_NONE, so nonpositive >> results are errors. > > True. discover_git_directory() already knows that negative return > values from setup_git_directory_gently_1() signal errors while 0 or > positive are OK. NOnononono. negative are not. 0 is not returned, so if we saw one, it would be an error. And positives are OK. Sorry for the confusion.
