On Wed, 19 Jul 2023 at 19:16, Glen Choo wrote: > As a micro-nit: there's some useful context behind your chosen design in > [1]. It would have been useful to link to it in the `---` context, or > perhaps send this series as v3 and v4 to [1]. > > [1] https://lore.kernel.org/git/20230712110732.8274-1-andy.koppe@xxxxxxxxx/ Point taken. > > + strbuf_expand(&sb, val, strbuf_expand_literal_cb, NULL); > > strbuf_expand() got removed in 'master' recently, so this should be > rebased. Done. I think I had started off main, wrongly assuming that it's the same as master. Thanks again, Andy
