Junio C Hamano <gitster@xxxxxxxxx> wrote: > Overall, the patch seems to be done very well when viewed as a > whole. Thanks for working on it. > > It is just I cannot be as confident as I would like to be in my > review when the single patch does several different things at once. > If it were split in steps, each step focusing on doing a single > thing well and describing well what it does and why, reviewers can > be more confident that they did not miss something important in the > patch(es). Thanks to Junio, Glen, Phil and the Review Club for the helpful reviews, especially the guidance on commit granularity. Sorry for not getting back to this sooner, but the v3 patch series addressing the review comments is now here: https://lore.kernel.org/git/20230715160730.4046-1-andy.koppe@xxxxxxxxx/T/#m46ad3ebbe3163821f649f7122edcabd619fc5837 Kind regards, Andy
