Re: Re* [PATCH v3 2/2] doc: revert: add discussion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 11, 2023 at 10:44:50AM -0700, Junio C Hamano wrote:
Junio C Hamano <gitster@xxxxxxxxx> writes:

Linus Arver <linusa@xxxxxxxxxx> writes:

Oswald Buddenhagen <oswald.buddenhagen@xxxxxx> writes:

while thinking about what to write, i came up with an idea for another
improvement: with (implicit) --edit, the template message would end up
being:

 This reverts commit <sha1>,
 because <PUT REASON HERE>.

This sounds great to me.

Oh, absolutely.  I rarely do a revert myself (other than reverting a
premature merge out of 'next'), but giving a better instruction in
the commit log editor buffer as template is a very good idea.

It might be just the matter of doing something like the attached
patch on top of Oswald's, reusing the existing code to instruct the
user to describe the reversion.

hmm, this seems to be going down a too narrow road - my idea was to make this fully orthogonal to reverting reverts in particular (note that i attached it to the generic "discussion" patch rather than the "reverts of reverts" one).
i didn't think about the integration with existing options yet.

regards



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux