On 23/07/13 01:27PM, Junio C Hamano wrote: > "D. Ben Knoble" <ben.knoble@xxxxxxxxx> writes: > > > "D. Ben Knoble" <ben.knoble@xxxxxxxxx> wrote: > > [...] > >> > >> Summary output: > >> > >> Test Summary Report > >> ------------------- > >> t2400-worktree-add.sh (Wstat: 256 Tests: > >> 227 Failed: 27) > >> Failed tests: 50-52, 91-93, 107-109, 123-125, 139-141 > >> 159-161, 175-177, 191-193, 207-209 > >> Non-zero exit status: 1 > >> > >> Proximate log entry: > >> > >> [16:19:43] t2400-worktree-add.sh .............................. > >> Dubious, test returned 1 (wstat 256, 0x100) > >> Failed 27/227 subtests > > [...] > > Given that the tests seem to randomly fail, I can believe if this is > due to a flakey test that needs to be fixed, but from what we can > see in the webpage of Cirrus CI, I cannot even guess what the > problem is. > > I do not offhand know how well the FreeBSD port has been maintained, > or those who have (or had once in the past) stake in it are keeping > an eye on it. Anybody? I wrote these tests[1]. All the tests that are failing are: - running `git worktree add` without `--orphan` or `--quiet`. - running in a repo with 1 local branch with a valid commit. - running in a worktree with an invalid/unborn HEAD. The resulting code path should be git failing with: - a warning containing the path to the HEAD file for the worktree that is in scope and the contents of that HEAD. - a hint to try using `--orphan`. - an error `fatal: invalid reference`. There are other minor variations between all the tests but these are the commonalities between the tests. No other tests stress that particular codepath. My guess is something in `can_use_local_ref()` (`builtin/worktree.c`) is triggering the crash. > > [...] 1. https://lore.kernel.org/git/20230517214711.12467-1-jacobabel@xxxxxxxxxx/
