On Mon, Jul 10, 2023 at 02:35:19PM -0700, Junio C Hamano wrote: > Does this "fix" anything, or just makes the resulting code clearer > and protects it from future breakage? I think it is the latter and > not having any test is justified. Nope, this doesn't change any existing behavior, and there is nothing broken with the original. So this is more about clarity and hardening this function against future breakage. Thanks, Taylor