On Mon, Jul 10, 2023 at 01:09:50PM -0700, Junio C Hamano wrote: > > git config pack.window 0 && > > P1=$(commit_and_pack 1) && > > P2=$(commit_and_pack 2) && > > P3=$(commit_and_pack 3) && > > P4=$(commit_and_pack 4) && > > - ls .git/objects/pack/*.pack >old-counts && > > + find .git/objects/pack -name "*.pack" -type f | sort >old-counts && > > test_line_count = 4 old-counts && > > git repack -a -d --keep-pack $P1 --keep-pack $P4 && > > - ls .git/objects/pack/*.pack >new-counts && > > + find .git/objects/pack -name "*.pack" -type f | sort >new-counts && > > grep -q $P1 new-counts && > > grep -q $P4 new-counts && > > test_line_count = 3 new-counts && > > I do not think "sort" in both of these added lines is doing anything > useful. Does the test break without this hunk and if so how? This is an error on my part; I don't think I realized that a bare ls gives sorted output, so changing these to 'find ... | sort' was unnecessary. I'll send a version that removes that noise. Thanks, Taylor
