Calvin Wan <calvinwan@xxxxxxxxxx> writes: >> Glen Choo <chooglen@xxxxxxxxxx> writes: >> >> > Could we add a is_pager/pager_in_use to that >> > function and push the pager.h dependency upwards? >> >> Bleh, I meant "Could we add a new is_pager/pager_in_use parameter to >> that function?" > > Refactoring the function signature to: > > parse_date_format(const char *format, struct date_mode *mode, int pager_in_use) > > as you suggested is a much better solution, thanks! I'll make that > change in the next reroll. Yeah, the date format "auto:" that changes behaviour between the output medium feels a serious layering violation, but given the constraints, it looks like the best thing to do. Thanks.
