On Tue, Jun 27, 2023 at 04:12:27PM +0000, brian m. carlson wrote: > > So I dunno. I'm mostly giving a heads-up, and seeing if you (or other > > reviewers in the thread) have an idea to make this "flag" thing less > > awful. I'm also happy to just do my topic separately, and then > > eventually circle back after yours is merged. > > I've picked up your patch as the first patch in the series and will send > it out in v3 in just a few minutes. Since I plan to have v3 be the last > round of this series, I'll let you send out any further changes as > fixups on top of that. Thanks, that is optimal from my perspective. :) The resulting series looks good to me, both the changes you integrated from me, but also the whole thing overall. It is a little funny to stuff the GIT_CONFIG_GLOBAL values into a string only to re-split them (versus passing around a string_list itself), but I think it's a reasonable compromise given the function interface. -Peff
