Pierre Habouzit schrieb:
On Mon, Oct 22, 2007 at 11:35:30AM +0000, Johannes Sixt wrote:
Pierre Habouzit schrieb:
On Mon, Oct 22, 2007 at 08:53:36AM +0000, Johannes Sixt wrote:
Pierre Habouzit schrieb:
+say_color () {
+ [ "$nocolor" = 0 ] && [ "$1" != '-1' ] && tput setaf "$1"
+ shift
+ echo "* $*"
+ tput op
^^^^^^^^
I am talking about this line.
+}
I wanted to point out that if tput is not
available, the second invocation will leave "tput: command not found"
behind on stderr. Therefore, I proposed to make the definition of
say_color() different depending on whether $color is set or not. Then you
don't need to test for $color twice inside the function.
Right we can do that. I'll try to rework the patch. and no it
shouldn't leave tput: command not found as I 2>/dev/null and I think the
shell doesn't print that in that case. At least my zsh doesn't.
There is no 2>/dev/null. Am I missing something?
-- Hannes
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
