On Fri, Jun 2, 2023 at 12:27 PM Alejandro R Sedeño <asedeno@xxxxxxxxxx> wrote: > > From: Alejandro R. Sedeño <asedeno@xxxxxxx> > > These definitions are used in cache.h, which can't include dir.h > without causing name-hash.c to have two definitions of > `struct dir_entry`. ...are _currently_ used in cache.h (your commit message is fine, just pointing it out for below...) > Both dir.h and cache.h include statinfo.h, and this seems a reasonable > place for these definitions. > > This change fixes a broken build issue on old SunOS. Maintainer note for Junio: en/header-split-cache-h-part-3 moves the inline functions in cache.h that use the DT_* defines, but that series should both textually and semantically merge cleanly with this change. (Just noting this for your peace of mind.) After en/header-split-cache-h-part-3 merges down, I might opt for a different fix (I'm still mulling it over), but that other fix isn't possible until cache.h is split up more. Alejandro's fix is the cleanest interim solution I can think of. Reviewed-by: Elijah Newren <newren@xxxxxxxxx>
