On Tue, May 16, 2023 at 01:57:50PM -0400, Taylor Blau wrote: > On Tue, May 16, 2023 at 10:24:24AM -0700, Junio C Hamano wrote: > > Recent header file shuffling missed this old user of ALLOC_GROW() > > that was inside "#ifdef NO_PTHREADS' section and forgot to include > > the new file, alloc.h, that defines the macro. > > Heh. I wrote an identical patch before lunch (which I just came back > from). Feel free to queue either, I honestly do not care which as long > as the bug is fixed :-). > > https://lore.kernel.org/git/db403de74da839084165f11dab05d71484457c6f.1684259780.git.me@xxxxxxxxxxxx/ OK, having now read both completely, I would say I have a vague preference for my version since it keeps the include at the top and unconditional, and has slightly more information in the patch message. But I do not prefer it so much over yours that I would be sad if you had already queued yours and didn't want to bother shuffling it around. Thanks, Taylor
