[BUG_REPORT] `git submodule update` segfaults

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



What did you do before the bug happened? (Steps to reproduce your issue)
Ran `git submodule update` after commenting out the url field in both
.gitmodules and the corresponding section for the submodule in .git/config.

What did you expect to happen? (Expected behavior)
Graceful handling of the situation.

What happened instead? (Actual behavior)
Segmentation fault.

Anything else you want to add:
The segfault results from `sub->url` being NULL here (actual segfault
comes a couple calls further):
https://github.com/git/git/blob/0df2c180904f6b709766f9c24669a9d01543f915/builtin/submodule--helper.c#LL2027C1-L2027C1

Possibly relevant: a similar snippet being properly protected against
null-pointer dereferencing:
https://github.com/git/git/blob/0df2c180904f6b709766f9c24669a9d01543f915/builtin/submodule--helper.c#L1243



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux