Junio C Hamano <gitster@xxxxxxxxx> writes: > Sergey Organov <sorganov@xxxxxxxxx> writes: > >> No problem from my side, but are you sure? > > Absolutely. > > I've seen people just say "we document a failed one" and leave it at > that, without attempting to fix. I am trying to see if pushing back > at first would serve as a good way to encourage these known failure > to be fixed, without accumulating too many expect_failure in our > test suite, which will waste cycles at CI runs (which do not need to > be reminded something is known to be broken). I will try not to do > this when I do not positively know the author of such a patch is > capable enough to provide a fix, though, and you are unlucky enough > to have shown your abilities in the past ;-) Thanks for the credit, but as my recent attempts to fix 2 obvious deficiencies in Git CI (one of them being my own) failed quite miserably, I figure I have no idea how these things in CI are to be treated, so I prefer to leave a fix to somebody else, who actually groks what makes sense in the Git UI, and what doesn't. That said, in case you still need the test with expect_success, below is one rerolled. Thanks, -- Sergey Organov --- >8 --- Subject: [PATCH] t4013: add test for "log --patch --no-patch" --patch followed by --no-patch is to be a no-op according to the "git log" manual page. In reality this sequence breaks --raw output though (and who knows what else?) Add test case for the issue. Signed-off-by: Sergey Organov <sorganov@xxxxxxxxx> --- t/t4013-diff-various.sh | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/t/t4013-diff-various.sh b/t/t4013-diff-various.sh index 5de1d190759f..32907bf142fc 100755 --- a/t/t4013-diff-various.sh +++ b/t/t4013-diff-various.sh @@ -457,6 +457,17 @@ diff-tree --stat --compact-summary initial mode diff-tree -R --stat --compact-summary initial mode EOF +# This should succeed as --patch followed by --no-patch sequence is to +# be a no-op according to the manual page. In reality it breaks --raw +# though. Needs to be fixed. +test_expect_success '--no-patch cancels --patch only' ' + git log --raw master >result && + process_diffs result >expected && + git log --patch --no-patch --raw >result && + process_diffs result >actual && + test_cmp expected actual +' + test_expect_success 'log -m matches pure log' ' git log master >result && process_diffs result >expected && -- 2.25.1
