On Fri, Mar 17, 2023 at 03:15:49PM -0700, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > There's code in git_connect() that checks whether we are doing a push > > with protocol_v2, and if so, drops us to protocol_v0 (since we only know > > how to do v0 for fetches). > > I had to read this three times to make sense out of it, and then > after reading the NEEDSWORK comment at the beginning of > git_connect(), started to suspect that there is a bit of typo there > that made it confusing to me. Either "(since we only know how to do > v2 for fetches)", or "(since we only know how to push via v0)", > perhaps. No matter how many times I proofread... :) Yes, it should be "we only know how to do v2 for fetches". > Other than that, superb reasoning and a very clear solution. Will > apply. Thanks. Thanks. Looks like you already fixed up s/v0/v2/ in what you queued. -Peff
