Re: [PATCH] git_connect(): fix corner cases in downgrading v2 to v0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeff King <peff@xxxxxxxx> writes:

> There's code in git_connect() that checks whether we are doing a push
> with protocol_v2, and if so, drops us to protocol_v0 (since we only know
> how to do v0 for fetches).

I had to read this three times to make sense out of it, and then
after reading the NEEDSWORK comment at the beginning of
git_connect(), started to suspect that there is a bit of typo there
that made it confusing to me.  Either "(since we only know how to do
v2 for fetches)", or "(since we only know how to push via v0)",
perhaps.

Other than that, superb reasoning and a very clear solution.  Will
apply.  Thanks.



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux