On Mon, Mar 06, 2023 at 03:44:11AM +0000, Robin H. Johnson wrote: > > diff --git a/t/t6020-bundle-misc.sh b/t/t6020-bundle-misc.sh > > index 7d40994991e..978c5b17ba5 100755 > > --- a/t/t6020-bundle-misc.sh > > +++ b/t/t6020-bundle-misc.sh > > @@ -606,4 +606,10 @@ test_expect_success 'verify catches unreachable, broken prerequisites' ' > > ) > > ' > > > > +test_expect_success 'bundle progress includes write phase' ' > > + GIT_PROGRESS_DELAY=0 \ > > + git bundle create --progress out.bundle --all 2>err && > > + grep 'Writing' err > > +' > > + > > test_done > > Suggestion: How about adding a test for --quiet that ensures no other > output? I had sort of assumed that we had those already, from the earlier work, but it looks like we don't. Squashing this in would do it, I think (we need test_terminal since otherwise we'd be quiet anyway): diff --git a/t/t6020-bundle-misc.sh b/t/t6020-bundle-misc.sh index 978c5b17ba5..7bbb351b7be 100755 --- a/t/t6020-bundle-misc.sh +++ b/t/t6020-bundle-misc.sh @@ -10,6 +10,7 @@ export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME . ./test-lib.sh . "$TEST_DIRECTORY"/lib-bundle.sh +. "$TEST_DIRECTORY"/lib-terminal.sh for cmd in create verify list-heads unbundle do @@ -612,4 +613,10 @@ test_expect_success 'bundle progress includes write phase' ' grep 'Writing' err ' +test_expect_success TTY '--quiet disables all bundle progress' ' + test_terminal env GIT_PROGRESS_DELAY=0 \ + git bundle --quiet create out.bundle --all 2>err && + test_must_be_empty err +' + test_done
