On Sat, Mar 04, 2023 at 05:55:13AM -0500, Jeff King wrote: ... > I'm marking it as "RFC" because it's undoing some of what Robin (cc'd) > did in the commit referenced below. But I remain unconvinced that it's a > useful direction. > -- >8 -- > Subject: bundle: turn on --all-progress-implied by default (snip) Signed-off-by: Robin H. Johnson <robbat2@xxxxxxxxxx> +1 to at least roll it into a RC. IIRC this was a mechanical mapping to expose the pack options into the bundle command; and a cleanup is worthwhile. (snip) > diff --git a/t/t6020-bundle-misc.sh b/t/t6020-bundle-misc.sh > index 7d40994991e..978c5b17ba5 100755 > --- a/t/t6020-bundle-misc.sh > +++ b/t/t6020-bundle-misc.sh > @@ -606,4 +606,10 @@ test_expect_success 'verify catches unreachable, broken prerequisites' ' > ) > ' > > +test_expect_success 'bundle progress includes write phase' ' > + GIT_PROGRESS_DELAY=0 \ > + git bundle create --progress out.bundle --all 2>err && > + grep 'Writing' err > +' > + > test_done Suggestion: How about adding a test for --quiet that ensures no other output? -- Robin Hugh Johnson Gentoo Linux: Dev, Infra Lead, Foundation Treasurer E-Mail : robbat2@xxxxxxxxxx GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85 GnuPG FP : 7D0B3CEB E9B85B1F 825BCECF EE05E6F6 A48F6136
Attachment:
signature.asc
Description: PGP signature
