On Wed, 15 Feb 2023 at 05:34, Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > > On Fri, Feb 10, 2023 at 11:00 PM Vinayak Dev <vinayakdev.sci@xxxxxxxxx> wrote: > > Should I re-send [v2] after making corrections for this mistake? > > That would make the corrections more obvious and the mistakes less. > > You should send a v3 which completely replaces v1 and v2. > > To prepare v3, use the "squash" (or "fixup") command of `git rebase > -i` to squash all three patches from v2 into a single patch, so that > v3 consists of just one patch. The squashed patch should contain only > changes to "apply.c"; specifically, changing #define to `enum`, and > changing the variable declarations from `int` to `enum`. > > You can also update the commit message of the squashed patch so that > it explains the reason for the patch: specifically, the debugger will > display the values symbolically rather than as mere numbers. > > Finally, proofread the commit message and the patch itself, and resubmit as v3. Ok! I have absolutely understood your points. I will roll out v3 with appropriate changes, as you suggest. Thanks a lot! Vinayak
