On Sat, 11 Feb 2023 at 03:31, Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Vinayak Dev <vinayakdev.sci@xxxxxxxxx> writes: > > > Revert changes to alias.c, and change variable types in apply.c > > When you send out a rerolled series, you do not have to show your > past mistakes. This [v2] is structured as a three patch series > whose first one makes a similar mess as what [v1] did, the second > one and the third one then revert some parts of that earlier mess. > > That is not what you want to show your reviewers, and more > importantly, that is not what we want to record in our history. > Rerolling a series is your chance to pretend that you are much > better programmer than you who wrote the [v1] patch. The review > exchange is to help you do that. Please take advantage of that. > > You may find "git rebase -i" is a useful tool to help you pretend > that you got to the ideal end result without these "I tried this > first, which was wrong in these points, which I correct in a > subsequent step" steps. > > Thanks. OK, I will keep that in mind before sending subsequent patches. Should I re-send [v2] after making corrections for this mistake? That would make the corrections more obvious and the mistakes less. Thanks a lot! Vinayak
