On Fri, Jan 20, 2023 at 1:55 AM Martin Ågren <martin.agren@xxxxxxxxx> wrote: > > On Fri, 20 Jan 2023 at 06:27, Elijah Newren via GitGitGadget > <gitgitgadget@xxxxxxxxx> wrote: > > > > As per the git-apply documentation for the `-C` option: > > Ensure at least <n> lines of surrounding context match...When fewer > > lines of surrounding context exist they all must match. > > > > The fact that format-patch was not passed a -U option to increase the > > number of context lines meant that there would still only be 3 lines of > > context to match on. So, anyone attempting to use this option in > > git-rebase would just be spinning their wheels and wasting time. I was > > one such user a number of years ago. > > I suppose someone might have something like GIT_DIFF_OPTS="--unified=20" > meaning they would actually have more context for their `-C` to act on. > So I guess there is a chance that someone somewhere has actually been > able to make use of `git rebase -C` after all? I'm not really arguing > either way -- just noting the possibility, as remote as it may be. > > Martin Ah, good point. And combined with Junio's point that -C is apparently about reducing rather than increasing context, I should just drop the patch.
