On Wed, Jan 18, 2023 at 10:26:40PM -0800, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > In hash_object(), we open a descriptor for each file to hash (whether we > > got the filename from the command line or --stdin-paths), but never > > close it. For the traditional code path which feeds the result to > > index_fd(), this is OK; it closes the descriptor for us. > > > > But 5ba9a93b39 (hash-object: add --literally option, 2014-09-11) a > > second code path which does not close the descriptor. > > A sentence without verb? "5ba9 (hash-...) added a second code path, > which does not close the descriptor." or something? Yes, the missing word was "added". Thanks. -Peff
