On 13/01/2023 20:22, Junio C Hamano wrote:
Jeff King <peff@xxxxxxxx> writes:
I had somewhat the opposite thought. The "break" command is special in
that it is not doing anything useful except returning control to the
user. And hence producing a message is a useful add-on. So I expected
the patch to just allow:
break this is a message the user will see
without any "#" at all.
Ah, I am OK with that, too.
That does close the door for further arguments, but I have trouble
imagining what they would be.
Making almost everything that the tool does not pay attention to
(like the patch title of "pick") into comments, floated by Elijah in
the thread, does sound another reasonable direction to go. If we
are not doing "pick 0f2d4b69 # the title of the commit", adding the
message without "#" to "break" might be a better way to go for
consistency.
Indeed, it seems the question is whether we want to make the changes
Elijah suggested - if so then we should use a "#" with the "break"
command as well but if not then it I agree it would be better not have
have "#" for comments with "break".
My impression is that there is some support for Elijah's suggestion and
no one has spoken up to oppose it so maybe we should go for that.
Best Wishes
Phillip
