Junio C Hamano <gitster@xxxxxxxxx> writes: >> +#if GIT_CURL_HAVE_CURLOPT_PROTOCOLS_STR >> +#define GIT_CURLOPT_REDIR_PROTOCOLS_STR CURLOPT_REDIR_PROTOCOLS_STR >> +#define GIT_CURLOPT_PROTOCOLS_STR CURLOPT_PROTOCOLS_STR >> +#else >> +#define GIT_CURLOPT_REDIR_PROTOCOLS_STR 0 >> +#define GIT_CURLOPT_PROTOCOLS_STR 0 >> #endif > > I find it a bit ugly that CURLOPT_* being used are all non-zero, but > it may be true in practice. Sorry for making the first half of the sentence unintelligible. I meant to say that it is ugly that the correctness of the solution depends on the real value for these macros being non-zero.