Re: [PATCH] dir: check for single file cone patterns

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 20/12/2022 15.33, Ævar Arnfjörð Bjarmason wrote:

On Tue, Dec 20 2022, William Sprent via GitGitGadget wrote:

From: William Sprent <williams@xxxxxxxxxxx>
[...]
+	if (!(given->flags & PATTERN_FLAG_MUSTBEDIR) &&
+	    !!strcmp(given->pattern, "/*")) {

Style: We use !! to convert 123 to 1 or whatever, but here we just care
about "not matched", so we can drop this !!strcmp() for strcmp().

Thanks. I'll drop the '!!' for next version.



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux